cleans up

This commit is contained in:
2019-07-01 15:41:13 +02:00
parent f6ee865088
commit 5f598aff24
5 changed files with 136 additions and 150 deletions

View File

@@ -1,114 +0,0 @@
use actix_web::{web, web::Json, Error, HttpResponse, Result};
use futures::Future;
use lootalot_db::{RunQueryDsl, Pool, DbConnection, QueryResult, ActionResult};
use lootalot_db::{Item, Player};
/// A wrapper providing an API over the database
/// It offers a convenient way to deal with connection
pub struct DbApi<'q>(&'q DbConnection);
impl<'q> DbApi<'q> {
/// Returns a DbApi using the user given connection
///
/// # Usage
/// ```
/// let conn = DbConnection::establish();
/// let api = DbApi::with_conn(&conn);
/// ```
pub fn with_conn(conn: &'q DbConnection) -> Self {
Self(conn)
}
/// Fetch the list of all players
///
/// This method consumes the DbApi object.
pub fn fetch_players(self) -> QueryResult<Vec<Player>> {
Player::fetch_list(self.0)
}
/// Wrapper for acting as a specific player
///
/// The DbApi is moved inside a new AsPlayer object.
///
/// # Usage
/// ```
/// let player_id: i32 = 1; // Id that references player in DB
/// let player = api.as_player(player_id);
/// ```
pub fn as_player(self, id: i32) -> AsPlayer<'q> {
AsPlayer { id, conn: self.0 }
}
}
/// A wrapper for interactions of players with the database
/// Possible actions are exposed as methods
pub struct AsPlayer<'q> {
id: i32,
conn: &'q DbConnection,
}
impl<'q> AsPlayer<'q> {
/// Fetch the content of a player's chest
pub fn loot(self) -> QueryResult<Vec<Item>> {
dbg!( Ok( Item::owned_by(self.id).load(self.conn)? ) )
}
/// Put a claim on a specific item
pub fn claim(self, item: i32) -> ActionResult {
Player::action_claim_object(self.id, item, self.conn)
}
}
// struct DbApi<'q>(&'q DbConnection);
// ::new() -> DbApi<'q> (Db finds a connection by itself, usefull for cli)
// ::with_conn(conn) -> DbApi<'q> (uses a user-defined connection)
// .fetch_players()
// .with_player(player_id) -> AsPlayer<'q>
// .loot() -> List of items owned (Vec<Item>)
// .claim(item_id) -> Success status (bool)
// .unclaim(item_id) -> Success status (bool)
// .sell(item_id) -> Success status (bool, earned)
// .income(wealth_data) -> Success status (bool, new_wealth)
// .with_admin()
// .resolve_claims()
//
/// Wraps call to the DbApi and process its result as a async HttpResponse
///
/// Provides a convenient way to call the api inside a route definition. Given a connection pool,
/// access to the api is granted in a closure. The closure is called in a blocking way and should
/// return a QueryResult.
/// If the query succeeds, it's result is returned as JSON data. Otherwise, an InternalServerError
/// is returned.
///
/// # Usage
/// ```
/// (...)
/// .route("path/to/",
/// move |pool: web::Data<Pool>| {
/// // user data can be processed here
/// // ...
/// db_call(pool, move |api| {
/// // ...do what you want with the api
/// }
/// }
/// )
/// ```
pub fn db_call<
J: serde::ser::Serialize + Send + 'static,
Q: Fn(DbApi) -> QueryResult<J> + Send + 'static,
>(
pool: web::Data<Pool>,
query: Q,
) -> impl Future<Item = HttpResponse, Error = Error> {
let conn = pool.get().unwrap();
web::block(move || {
let api = DbApi::with_conn(&conn);
query(api)
})
.then(|res| match res {
Ok(players) => HttpResponse::Ok().json(players),
Err(e) => {
dbg!(&e);
HttpResponse::InternalServerError().finish()
}
})
}

View File

@@ -3,7 +3,6 @@ extern crate env_logger;
extern crate actix_web;
extern crate lootalot_db;
mod api;
mod server;
fn main() {

View File

@@ -1,11 +1,53 @@
use std::env;
use futures::Future;
use actix_files as fs;
use actix_web::{web, App, HttpServer};
use lootalot_db::Pool;
use crate::api;
use actix_web::{web, App, HttpServer, HttpResponse, Error};
use lootalot_db::{Pool, DbApi, QueryResult};
type AppPool = web::Data<Pool>;
/// Wraps call to the DbApi and process its result as a async HttpResponse
///
/// Provides a convenient way to call the api inside a route definition. Given a connection pool,
/// access to the api is granted in a closure. The closure is called in a blocking way and should
/// return a QueryResult.
/// If the query succeeds, it's result is returned as JSON data. Otherwise, an InternalServerError
/// is returned.
///
/// # Usage
/// ```
/// (...)
/// .route("path/to/",
/// move |pool: web::Data<Pool>| {
/// // user data can be processed here
/// // ...
/// db_call(pool, move |api| {
/// // ...do what you want with the api
/// }
/// }
/// )
/// ```
pub fn db_call<
J: serde::ser::Serialize + Send + 'static,
Q: Fn(DbApi) -> QueryResult<J> + Send + 'static,
>(
pool: AppPool,
query: Q,
) -> impl Future<Item = HttpResponse, Error = Error> {
let conn = pool.get().unwrap();
web::block(move || {
let api = DbApi::with_conn(&conn);
query(api)
})
.then(|res| match res {
Ok(players) => HttpResponse::Ok().json(players),
Err(e) => {
dbg!(&e);
HttpResponse::InternalServerError().finish()
}
})
}
pub(crate) fn serve() -> std::io::Result<()> {
let www_root: String = env::var("WWW_ROOT").expect("WWW_ROOT must be set");
dbg!(&www_root);
@@ -17,14 +59,14 @@ pub(crate) fn serve() -> std::io::Result<()> {
.route(
"/players",
web::get().to_async(move |pool: AppPool| {
api::db_call(pool, move |api| api.fetch_players())
db_call(pool, move |api| api.fetch_players())
}),
)
.route(
"/loot/{player_id}",
web::get().to_async(move |pool: AppPool, player_id: web::Path<i32>| {
let player_id: i32 = *player_id;
api::db_call(pool, move |api| api.as_player(player_id).loot())
db_call(pool, move |api| api.as_player(player_id).loot())
}),
)
.service(fs::Files::new("/", www_root.clone()).index_file("index.html"))