rust/lootalot
1
0
Fork 0
Code Issues 3 Pull Requests Releases Wiki Activity

formats code

Browse Source
This commit is contained in:
Arthur Gerbaud
2019-07-20 15:00:28 +02:00
parent 0636829fdd
commit 51a3d00d03
5 changed files with 106 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

128
lootalot_db/src/lib.rs
View File

@@ -49,7 +49,6 @@ impl ActionStatus<()> {
}
}
impl<T: Default + serde::Serialize> ActionStatus<T> {
fn nop() -> ActionStatus<T> {
Self {
@@ -168,7 +167,7 @@ impl<'q> AsPlayer<'q> {
.execute(self.conn)
.and_then(|r| match r {
1 => Ok(self.update_wealth(-(price as f32)).unwrap()),
_ => Ok(ActionStatus::nop())
_ => Ok(ActionStatus::nop()),
})
}
/// Sell an item from this player chest
@@ -177,15 +176,22 @@ impl<'q> AsPlayer<'q> {
///
/// This currently panics if player wealth fails to be updated, as this is
/// a serious error. TODO: handle restoring of sold item in case of wealth update failure.
pub fn sell(self, loot_id: i32, _price_mod: Option<f32>) -> ActionResult<Option<(i32, i32, i32, i32)>> {
pub fn sell(
self,
loot_id: i32,
_price_mod: Option<f32>,
) -> ActionResult<Option<(i32, i32, i32, i32)>> {
// Check that the item belongs to player
let exists_and_owned: bool = diesel::select(models::Loot::owns(self.id, loot_id))
.get_result(self.conn)?;
let exists_and_owned: bool =
diesel::select(models::Loot::owns(self.id, loot_id)).get_result(self.conn)?;
if !exists_and_owned {
return Ok(ActionStatus::nop());
}
use schema::looted::dsl::*;
let loot_value = looted.find(loot_id).select(base_price).first::<i32>(self.conn)?;
let loot_value = looted
.find(loot_id)
.select(base_price)
.first::<i32>(self.conn)?;
let sell_value = (loot_value / 2) as f32;
diesel::delete(looted.find(loot_id))
.execute(self.conn)
@@ -193,9 +199,9 @@ impl<'q> AsPlayer<'q> {
// On deletion, update this player wealth
1 => Ok(self.update_wealth(sell_value).unwrap()),
_ => Ok(ActionStatus {
executed: false,
response: None,
}),
executed: false,
response: None,
}),
})
}
@@ -208,7 +214,7 @@ impl<'q> AsPlayer<'q> {
.find(self.id)
.select((cp, sp, gp, pp))
.first::<models::Wealth>(self.conn)?;
// TODO: improve this
// TODO: improve thisdiesel dependant transaction
// should be move inside a WealthUpdate method
let updated_wealth = models::Wealth::from_gp(current_wealth.to_gp() + value_in_gp);
// Difference in coins that is sent back
@@ -228,9 +234,7 @@ impl<'q> AsPlayer<'q> {
}
/// Put a claim on a specific item
pub fn claim(self, item: i32) -> ActionResult<()> {
// TODO: check that looted item exists
let exists: bool = diesel::select(models::Loot::exists(item))
.get_result(self.conn)?;
let exists: bool = diesel::select(models::Loot::exists(item)).get_result(self.conn)?;
if !exists {
return Ok(ActionStatus::nop());
};
@@ -244,11 +248,12 @@ impl<'q> AsPlayer<'q> {
pub fn unclaim(self, item: i32) -> ActionResult<()> {
use schema::claims::dsl::*;
diesel::delete(
claims.filter(loot_id.eq(item))
.filter(player_id.eq(self.id)),
)
.execute(self.conn)
.map(ActionStatus::was_updated)
claims
.filter(loot_id.eq(item))
.filter(player_id.eq(self.id)),
)
.execute(self.conn)
.map(ActionStatus::was_updated)
}
}
@@ -335,12 +340,16 @@ mod tests {
#[test]
fn test_player_updates_wealth() {
let conn = test_connection();
DbApi::with_conn(&conn).as_admin()
DbApi::with_conn(&conn)
.as_admin()
.add_player("PlayerName".to_string(), 403.21)
.unwrap();
let diff = DbApi::with_conn(&conn).as_player(1)
.update_wealth(-401.21).unwrap()
.response.unwrap();
let diff = DbApi::with_conn(&conn)
.as_player(1)
.update_wealth(-401.21)
.unwrap()
.response
.unwrap();
// Check the returned diff
assert_eq!(diff, (-1, -2, -1, -4));
let players = DbApi::with_conn(&conn).fetch_players().unwrap();
@@ -355,7 +364,8 @@ mod tests {
#[test]
fn test_admin_add_player() {
let conn = test_connection();
let result = DbApi::with_conn(&conn).as_admin()
let result = DbApi::with_conn(&conn)
.as_admin()
.add_player("PlayerName".to_string(), 403.21)
.unwrap();
assert_eq!(result.executed, true);
@@ -363,21 +373,31 @@ mod tests {
assert_eq!(players.len(), 2);
let new_player = players.get(1).unwrap();
assert_eq!(new_player.name, "PlayerName");
assert_eq!((new_player.cp, new_player.sp, new_player.gp, new_player.pp), (1, 2, 3, 4));
assert_eq!(
(new_player.cp, new_player.sp, new_player.gp, new_player.pp),
(1, 2, 3, 4)
);
}
#[test]
fn test_admin_resolve_claims() {
let conn = test_connection();
let claims = DbApi::with_conn(&conn).fetch_claims().unwrap();
assert_eq!(claims.len(), 0);
assert_eq!(true, false); // Failing as test is not complete
}
#[test]
fn test_player_claim_item() {
let conn = test_connection();
DbApi::with_conn(&conn).as_admin()
.add_player("Player".to_string(), 0.0).unwrap();
DbApi::with_conn(&conn).as_admin()
.add_loot(vec![("Épée", 25),]).unwrap();
DbApi::with_conn(&conn)
.as_admin()
.add_player("Player".to_string(), 0.0)
.unwrap();
DbApi::with_conn(&conn)
.as_admin()
.add_loot(vec![("Épée", 25)])
.unwrap();
// Claim an existing item
let result = DbApi::with_conn(&conn).as_player(1).claim(1).unwrap();
assert_eq!(result.executed, true);
@@ -394,10 +414,14 @@ mod tests {
#[test]
fn test_player_unclaim_item() {
let conn = test_connection();
DbApi::with_conn(&conn).as_admin()
.add_player("Player".to_string(), 0.0).unwrap();
DbApi::with_conn(&conn).as_admin()
.add_loot(vec![("Épée", 25),]).unwrap();
DbApi::with_conn(&conn)
.as_admin()
.add_player("Player".to_string(), 0.0)
.unwrap();
DbApi::with_conn(&conn)
.as_admin()
.add_loot(vec![("Épée", 25)])
.unwrap();
// Claim an existing item
let result = DbApi::with_conn(&conn).as_player(1).claim(1).unwrap();
assert_eq!(result.executed, true);
@@ -408,8 +432,6 @@ mod tests {
assert_eq!(result.executed, false);
let claims = DbApi::with_conn(&conn).fetch_claims().unwrap();
assert_eq!(claims.len(), 0);
}
/// All-in-one checks one a simple buy/sell procedure
@@ -419,11 +441,17 @@ mod tests {
#[test]
fn test_buy_sell_simple() {
let conn = test_connection();
DbApi::with_conn(&conn).as_admin().add_player("Player".to_string(), 1000.0).unwrap();
DbApi::with_conn(&conn)
.as_admin()
.add_player("Player".to_string(), 1000.0)
.unwrap();
// Buy an item
let bought = DbApi::with_conn(&conn).as_player(1).buy("Sword", 800).unwrap();
let bought = DbApi::with_conn(&conn)
.as_player(1)
.buy("Sword", 800)
.unwrap();
assert_eq!(bought.executed, true); // Was updated ?
assert_eq!(bought.response, Some((0,0,0,-8))); // Returns diff of player wealth ?
assert_eq!(bought.response, Some((0, 0, 0, -8))); // Returns diff of player wealth ?
let chest = DbApi::with_conn(&conn).as_player(1).loot().unwrap();
assert_eq!(chest.len(), 1);
let loot = chest.get(0).unwrap();
@@ -433,9 +461,12 @@ mod tests {
let player = players.get(1).unwrap();
assert_eq!(player.pp, 2);
// Sell back
let sold = DbApi::with_conn(&conn).as_player(1).sell(loot.id, None).unwrap();
let sold = DbApi::with_conn(&conn)
.as_player(1)
.sell(loot.id, None)
.unwrap();
assert_eq!(sold.executed, true);
assert_eq!(sold.response, Some((0,0,0,4)));
assert_eq!(sold.response, Some((0, 0, 0, 4)));
let chest = DbApi::with_conn(&conn).as_player(1).loot().unwrap();
assert_eq!(chest.len(), 0);
let players = DbApi::with_conn(&conn).fetch_players().unwrap();
@@ -446,12 +477,15 @@ mod tests {
#[test]
fn test_admin_add_loot() {
let conn = test_connection();
assert_eq!(0, DbApi::with_conn(&conn).as_player(0).loot().unwrap().len());
let loot_to_add = vec![
("Cape d'invisibilité", 8000),
("Arc long", 25),
];
let result = DbApi::with_conn(&conn).as_admin().add_loot(loot_to_add.clone()).unwrap();
assert_eq!(
0,
DbApi::with_conn(&conn).as_player(0).loot().unwrap().len()
);
let loot_to_add = vec![("Cape d'invisibilité", 8000), ("Arc long", 25)];
let result = DbApi::with_conn(&conn)
.as_admin()
.add_loot(loot_to_add.clone())
.unwrap();
assert_eq!(result.executed, true);
let looted = DbApi::with_conn(&conn).as_player(0).loot().unwrap();
assert_eq!(looted.len(), 2);
@@ -463,5 +497,3 @@ mod tests {
}
}
}

5
lootalot_db/src/models/claim.rs
View File

@@ -24,9 +24,6 @@ pub(crate) struct NewClaim {
impl NewClaim {
pub(crate) fn new(player_id: i32, loot_id: i32) -> Self {
Self {
player_id,
loot_id
}
Self { player_id, loot_id }
}
}

2
lootalot_db/src/models/item.rs
View File

@@ -1,4 +1,4 @@
use crate::schema::{looted};
use crate::schema::looted;
use diesel::dsl::{exists, Eq, Filter, Find, Select};
use diesel::expression::exists::Exists;
use diesel::prelude::*;

5
lootalot_db/src/models/player.rs
View File

@@ -99,7 +99,10 @@ impl<'a> NewPlayer<'a> {
let (cp, sp, gp, pp) = Wealth::from_gp(wealth_in_gp).as_tuple();
Self {
name,
cp, sp, gp, pp,
cp,
sp,
gp,
pp,
}
}
}