diff --git a/planner/src/solver.rs b/planner/src/solver.rs index b93f36d..b1f1379 100644 --- a/planner/src/solver.rs +++ b/planner/src/solver.rs @@ -19,19 +19,21 @@ impl fmt::Debug for Domain { } } -type AssignMap<'a, V> = HashMap>; +type Variables<'a, V> = HashMap>; -/// Returns all possible Updates for next assignements. -/// They are added to the stack, just after a Clear for the next variable -fn assign_next<'a,'b, V>(assign: &'b AssignMap<'a, V>, domain: &'a Domain) +/// Returns all possible Updates for next assignements, prepended with +/// a Clear to ensure the variable is unset before when leaving the branch. +fn assign_next<'a,'b, V>(assign: &'b Variables<'a, V>, domain: &'a Domain) -> Option>> where V: fmt::Debug { // Panics on empty domain if domain.values.is_empty() { panic!("No values in domain : {:?}", domain); }; + // TODO: should be able to inject a choosing strategy if let Some((key,_)) = assign.iter().find(|(_, val)| val.is_none()) { let mut updates = vec![Assignment::Clear(key.clone())]; + // TODO: should be able to filter domain values (inference, pertinence) for value in domain.values.iter() { updates.push(Assignment::Update(key.clone(), value)); } @@ -42,7 +44,7 @@ fn assign_next<'a,'b, V>(assign: &'b AssignMap<'a, V>, domain: &'a Domain) } /// Check if any constraint is violated -fn check_consistency<'a, V>(assign: &'a AssignMap<'a, V>, constraint: fn(&AssignMap<'a,V>) -> bool) -> bool { +fn check_consistency<'a, V>(assign: &'a Variables<'a, V>, constraint: fn(&Variables<'a,V>) -> bool) -> bool { constraint(assign) } @@ -53,15 +55,10 @@ enum Assignment<'a, V> { /// Visit all possible solutions, using a stack. -/// A single mutable map is used to lay out every outcome. -/// Using the stack to Update or Clear values : -/// - After an Update : run assign_next to stack next updates. If there are none, -/// check for consistency, store in solutions if valid and close the branch (Clear) -/// - After a Clear : simply visit the next node on the stack. -fn solve_all<'a, V: Clone + fmt::Debug>(mut assign: AssignMap<'a, V>, domain: &'a Domain, is_valid: fn(&AssignMap<'a,V>) -> bool) - -> Vec> +fn solve_all<'a, V: Clone + fmt::Debug>(mut assign: Variables<'a, V>, domain: &'a Domain, is_valid: fn(&Variables<'a,V>) -> bool) + -> Vec> { - let mut solutions: Vec> = vec![]; + let mut solutions: Vec> = vec![]; let mut stack: Vec> = vec![]; stack.append(&mut assign_next(&assign,domain).unwrap()); loop { @@ -69,18 +66,20 @@ fn solve_all<'a, V: Clone + fmt::Debug>(mut assign: AssignMap<'a, V>, domain: &' if node.is_none() { break; }; match node.unwrap() { Assignment::Update(key, val) => { + // Assign the variable and open new branches, if any. *assign.get_mut(&key).unwrap() = Some(val); - // Search for next assignments // TODO: handle case of empty domain.values if let Some(mut nodes) = assign_next(&assign, domain) { stack.append(&mut nodes); } else { + // Assignements are completed if is_valid(&assign) { solutions.push(assign.clone()); }; }; }, Assignment::Clear(key) => { + // We are closing this branch, unset the variable *assign.get_mut(&key).unwrap() = None; }, }; @@ -95,15 +94,15 @@ mod tests { fn test_solver_find_pairs() { use super::*; // Find all pairs of two differents - let assign: AssignMap = [ + let assign: Variables = [ ("Left".to_string(), None), ("Right".to_string(), None), ].iter().cloned().collect(); let domain = Domain::new(vec![1,2,3]); - let constraint = |assign: &AssignMap| { + let constraint = |assign: &Variables| { assign.get("Left").unwrap() == assign.get("Right").unwrap() }; - let solutions: Vec> = vec![ + let solutions: Vec> = vec![ [("Left".to_string(), Some(&3)), ("Right".to_string(), Some(&3)),].iter().cloned().collect(), [("Left".to_string(), Some(&2)), ("Right".to_string(), Some(&2)),].iter().cloned().collect(), [("Left".to_string(), Some(&1)), ("Right".to_string(), Some(&1)),].iter().cloned().collect(),